GL Renderer : Fix custom mesh light texture visualisations #6066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were broken by cfc3857, where we assumed that such visualisations should be rendered with the Display color space. This led to them being rendered after the main Scene color space, meaning that the depth test prevented the texture visualisation from being seen. We now use a heuristic that means such visualisations are rendered first in Scene color space instead. In theory we could extend the Visualiser API to allow two states to be specified - one for Display space and one for Scene space. But that would require an ABI break, and we want this fix to go into 1.3. We also have so few uses for the visualisation state that it seems like overkill at this point. Fixes GafferHQ#6002.
ivanimanishi
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were broken by cfc3857, where we assumed that such visualisations should be rendered with the Display color space. This led to them being rendered after the main Scene color space, meaning that the depth test prevented the texture visualisation from being seen. We now use a heuristic that means such visualisations are rendered first in Scene color space instead.
In theory we could extend the Visualiser API to allow two states to be specified - one for Display space and one for Scene space. But that would require an ABI break, and we want this fix to go into 1.3. We also have so few uses for the visualisation state that it seems like overkill at this point.
Fixes #6002.